-
Notifications
You must be signed in to change notification settings - Fork 411
MSC4344: Strike deprecated SRV service name. #4344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jason Volk <jason@zemos.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation requirements:
- Data to show the SRV name isn't depended upon by a statistically significant amount of servers
due to adverse possession. The replacement service name `matrix-fed` | ||
became active on the same date of August 19, 2023. After an elapsed | ||
grace-period of two years, the deprecated service name is to be stricken | ||
from the specification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to either see data on whether there's been enough time, or matrix-org/matrix-federation-tester#142 deployed for some time (or ideally, both).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I would consider a working implementation of matrix-org/matrix-federation-tester#142 a blocker for this.
Frankly, I think it was a mistake to have merged MSC4040 without updating the federation tester.
@@ -0,0 +1,36 @@ | |||
# MSC4344: Strike deprecated SRV service name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure where to put it but since in the other thread the fed tester comes up I want to mention as another data point that https://connectivity-tester.mtrnord.blog/ does support both old and new SRV records at this time:
https://github.com/MTRNord/rust-federation-tester/blob/main/crates/server/src/utils.rs#L444
(see also DNS Resolution tab for https://connectivity-tester.mtrnord.blog/?serverName=4.msc4040.s.resolvematrix.dev )
rendered