MSC4337: Appservice API to supplement user profiles #4337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
changed the title
Half-Shot
commented
Sep 1, 2025
| @@ -0,0 +1,147 @@ | |||
| # MSC4337: Appservice API to supplement user profiles | |||
There was a problem hiding this comment.
Implementations:
- Synapse (partial, no unstable prefixes)
- [Bot-SDK][] TBD
- [Implemenation)[] TBD
ara4n
changed the title
turt2live
added
proposal
clokep
reviewed
Sep 2, 2025
Comment on lines
+21
to
+24
| - `origin_server` The server name of the server requesting the profile, *if* the profile is requested | ||
| over federation. Otherwise, omit. | ||
| - `from_user_id` The user MxID of the user requesting the profile, *if* the requesting user is known. | ||
| Otherwise, omit. |
There was a problem hiding this comment.
What error is used if both are provided? Is it valid to provide neither?
Comment on lines
+87
to
+89
| Application services may respond with a `404` `M_NOT_FOUND` if they do not provide any information | ||
| for the given `userId`. They may also choose to do this if they do not want to divulge information | ||
| about a given user to another user or service. |
There was a problem hiding this comment.
How does this affect merging behavior?
|
|
||
| ### Application service selection | ||
|
|
||
| Any homeserver with a matching `namespaces.users` field for the requested `userId` should be used |
There was a problem hiding this comment.
Suggested change
| Any homeserver with a matching `namespaces.users` field for the requested `userId` should be used | |
| Any application service with a matching `namespaces.users` field for the requested `userId` should be used |
Maybe? I'm not sure what this sentence is saying.
Comment on lines
+101
to
+103
| when querying the profile. The resulting profile should be merged together. The order of application services | ||
| here is **NOT** stable, and so if multiple application services set the same field on the same user | ||
| then there is potential for instability. Server admins should take care not to register multiple application |
There was a problem hiding this comment.
Is this already an issue today with overlapping ASes for other features, or new to this feature?
Comment on lines
+56
to
+57
| The homeserver should *always* request the profile from the application service even if the `key` is already | ||
| present in the user's stored profile. For instance, given a profile of: |
There was a problem hiding this comment.
Always sounds strong, it is only when an AS has some control over a user ID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered