Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC4027: Propose method of specifying custom images in reactions #4027

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

MSC4027: Propose method of specifying custom images in reactions #4027

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d4ff1c7
Propose method of specifying custom images in reactions
sumnerevans May 6, 2023
cdfe089
Add mention of multiple MXC URIs pointing to the same file
sumnerevans Jun 12, 2023
c86338a
Update shortcode unstable field name
sumnerevans Jun 12, 2023
75473cc
Remove recommendation for detecting if a string is an MXC URI
sumnerevans Jun 30, 2023
5424ea8
Specify that shortcode should start & end with ':'
sumnerevans Jun 30, 2023
2ac5328
Clarify that shortcode must be a string
sumnerevans Jun 30, 2023
badc1ba
Add shortcode length check verbiage
sumnerevans Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add shortcode length check verbiage 
Signed-off-by: Sumner Evans <sumner@beeper.com>
  • Loading branch information
@sumnerevans
sumnerevans committed Sep 5, 2023
commit badc1baa85acd3beffa2463cfee104182f12432c
7 changes: 7 additions & 0 deletions proposals/4027-custom-images-in-reactions.md
View file
Open in desktop
sumnerevans marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mscbot concern Needs to be reviewed against other custom emoji/sticker MSCs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in particular, this MSC sets up grammar for emoji shortcodes in Matrix, which we'll want to double-check aligns with whatever MSC defines sharable image packs.

@turt2live did you have anything else in mind? The rest is fairly reaction-specific IMO.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shortcodes and feature as a whole are conflicting, imo. Specific impact to be determined once the remainder of the stack is looked at :)

(I plan to do this over the next 2ish weeks, barring other commitments - will hand over ~next week if things go poorly on my side)

Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,13 @@ This proposal suggests two changes to events with the `m.annotation` relation.
the annotation, as alt-text, or if the client does not support rendering
images.

The `shortcode` must have a length of less than or equal to 100 bytes
(including the colons at the beginning and end of the string). This
restriction must be enforced by servers when sending reactions, but servers
should not reject events coming across federation due to having too many
bytes in the `shortcode` field. Servers may still opt to locally redact
events having too many bytes in the `shortcode` field.

Example custom image reaction event content

```json
Expand Down