-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC3932: Extensible events room version push rule feature flag #3932
Open
turt2live
wants to merge
2
commits into
main
Choose a base branch
from
travis/msc/extev/rver-cond
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
50 changes: 50 additions & 0 deletions
50
proposals/3932-extensible-events-room-ver-push-rule-condition.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
# MSC3932: Extensible events room version push rule feature flag | ||
|
||
As defined by [MSC3931](https://github.com/matrix-org/matrix-spec-proposals/pull/3931), push rules | ||
can be disabled or enabled based on what the room version itself supports feature-wise. This MSC | ||
introduces a feature flag for [MSC1767](https://github.com/matrix-org/matrix-spec-proposals/pull/1767), | ||
making it possible to restrict extensible events to an appropriate room version through notifications. | ||
|
||
A theory with this approach is that if push rules (and therefore notifications) are denied for extensible | ||
events, they are even less likely to be sent in inappropriate room versions. | ||
|
||
## Proposal | ||
|
||
For room versions supporting extensible events, they declare support for an `m.extensible_events` | ||
feature flag. | ||
|
||
Push rules which don't specify a `room_version_supports` condition are assumed to *not* support | ||
extensible events and are therefore expected to be treated as disabled when a room version *does* | ||
support extensible events. This is to ensure that legacy rules do not trigger in new room versions, | ||
similar to how this MSC aims to only enable certain push rules in applicable room versions. | ||
|
||
The above rule does *not* apply to the following push rule IDs: | ||
* `.m.rule.master` | ||
* `.m.rule.roomnotif` | ||
* `.m.rule.contains_user_name` | ||
|
||
Note that this MSC intentionally considers the lack of the condition rather than the lack of feature | ||
flag check on the push rule: this is intentional as the timeline for extensible events appears to | ||
show that this "push rules feature flags" system will land at the same time as extensible events, | ||
causing all future MSCs to consider extensible events too. | ||
|
||
Any room version which supports MSC1767's described room version is required to list this new feature | ||
flag. | ||
|
||
## Potential issues | ||
|
||
There is complexity in understanding how to apply the feature flag's condition to existing push rules, | ||
however through implementation effort it will become clearer. | ||
|
||
## Alternatives | ||
|
||
None discovered. | ||
|
||
## Security considerations | ||
|
||
No new considerations apply. | ||
|
||
## Unstable prefix | ||
|
||
While this MSC is not considered stable, implementations should use `org.matrix.msc3932.*` in place of | ||
`m.*` throughout this proposal. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per #3952, we should require that the deprecated push rules be ignored in supported room versions. This would mean that clients can avoid sending empty/useless objects on their events.
It's unclear if we'd want to support
m.mentions
as a mixin or regular content block though - either works.