-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] MSC3898: Native Matrix VoIP signalling for cascaded foci (SFUs, MCUs...) #3898
Draft
SimonBrandner
wants to merge
30
commits into
main
Choose a base branch
from
SimonBrandner/msc/sfu
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
750087f
Native Matrix VoIP signalling for cascaded SFUs
SimonBrandner aa53398
Update MSC number
SimonBrandner de302cb
Link to diagrams from MSC3401
SimonBrandner 7474782
Use correct number for file
SimonBrandner 5cad46d
Update sub and unsub ops
SimonBrandner 2cbc2d6
Merge remote-tracking branch 'upstream/main' into SimonBrandner/msc/sfu
SimonBrandner f542fcb
Give a reason for specifying res in metadata
SimonBrandner 6f01a94
Specify foci by `device_id` too
SimonBrandner 575e16c
Fixup some json
SimonBrandner 33b1880
Typo
SimonBrandner 65faee4
Specify how to handle foci better
SimonBrandner 9882c97
Amend TODOs
SimonBrandner c66bbe4
Add rationale behind usage of data channels
daniel-abramov 1b2d740
Add TODO
SimonBrandner feb064b
Update event types
SimonBrandner d96d101
Add unstable prefixes
SimonBrandner d538e1e
Use `subscribe` instead of `select`
SimonBrandner 91470a2
`op` -> `event`
SimonBrandner 2ef7425
Fixup formatting
SimonBrandner 5a186e4
Use `content`
SimonBrandner b461525
Namespace things
SimonBrandner e49e80d
Further namespacing
SimonBrandner 6b3fd47
Update the events to match current Matrix
SimonBrandner bf52e02
Fix typo
SimonBrandner f81dd9d
Use `subscribe`/`unsbuscribe`
SimonBrandner 9c32b96
Add informational section on active/preferred foci.
dbkr 6f8c9d1
Change keepalives to ping/pong
dbkr ecf2425
Add empty line
SimonBrandner bf04b17
Fix event name
SimonBrandner 1896fc7
Remove encryption section as it's glossing over details
SimonBrandner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Amend TODOs
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
- Loading branch information
commit 9882c97c211135a4e6b4455b8830cb8e92fd95ee
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts: how we load balance between SFUs and manage availability will have a bearing on this, ie. would we expect SFUs to become unavailable when they get restarted / updated and therefore how often a client expect its SFU (or list of SFUs?) to change?