-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] MSC3814: Dehydrated devices with SSSS #3814
Draft
uhoreg
wants to merge
25
commits into
matrix-org:main
Choose a base branch
from
uhoreg:shrivelled_sessions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
80243a4
Initial proposal for dehydrated devices with SSSS
uhoreg ed2c5eb
use MSC number
uhoreg 703281e
wording improvements and clarifications
uhoreg 0a149c5
Uploading a dehydrated device now uploads the public keys as well
poljar a4e87a6
Make the next_batch token non-optional in the response
poljar 3827bc0
Let's not delete to-device events when a client receives them
poljar 12acd43
Introduce the DELETE endpoint
poljar f756db3
Attempt to define the dehydration format
poljar 6223db4
Don't use operatorname, try to unwedge the Latex
poljar e3c9ac8
More Latex tweaks
poljar 7f24f0d
Remove the bytes unit from every single row, put it in the header
poljar f85c18d
Attempt to fix the math rendering
poljar 4954c27
Align the table headers for the pickle format
poljar 087154a
Fix JSON example
uhoreg e7c8266
link to fallback key spec
uhoreg cf5ae99
add dehydrated flag
uhoreg d751d33
Apply suggestions from code review
uhoreg 11149e4
define new format and add more security notes
uhoreg 1500897
suggest dropping to-device messages sent from a dehydrated device
uhoreg 5742c52
link to the base64 format that we use
uhoreg a58288a
we need the ed25519 key after all
uhoreg 21a3d67
add note about URL-safe base64
uhoreg 6be9078
update dehydration format
uhoreg ec17903
fix typo
uhoreg 9d6d059
fix typo
uhoreg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Attempt to fix the math rendering
- Loading branch information
commit f85c18db89e454d539958e152c6202f36d5736fd
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if I'm reading the iOS implementation correctly, the key is encoded with unpadded base64 (as is done with the other keys in secret storage)