MSC2367: Add reason field to all membership events #2367

erikjohnston · 2019-11-26T11:21:51Z

Relates to:

proposals/2367-membership-reasons.md

anoadragon453

Short, sweet and useful.

uhoreg · 2019-11-26T14:33:54Z

proposals/2367-membership-reasons.md

+
+### Leaving a Room
+
+A user may wish to leave a room e.g. because the room is no longer relevant


FWIW, leaving is already covered by MSC1983

Haha, great!

turt2live

Great extension to #1983

proposals/2367-membership-reasons.md

erikjohnston · 2019-11-26T15:11:13Z

@mscbot fcp merge

mscbot · 2019-11-26T15:11:29Z

Team member @erikjohnston has proposed to merge this. The next step is review by the rest of the tagged people:

No concerns currently listed.

Once at least 75% of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

mscbot · 2019-11-27T14:36:58Z

🔔 This is now entering its final comment period, as per the review above. 🔔

mscbot · 2019-12-02T15:11:46Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

…s#2367)

bmarty · 2019-12-06T16:38:11Z

FTR, implemented in RiotX here: element-hq/element-android#738

…s#2367)

Synapse 1.7.0rc1 (2019-12-09) ============================= Features -------- - Implement per-room message retention policies. ([\#5815](#5815), [\#6436](#6436)) - Add etag and count fields to key backup endpoints to help clients guess if there are new keys. ([\#5858](#5858)) - Add `/admin/v2/users` endpoint with pagination. Contributed by Awesome Technologies Innovationslabor GmbH. ([\#5925](#5925)) - Require User-Interactive Authentication for `/account/3pid/add`, meaning the user's password will be required to add a third-party ID to their account. ([\#6119](#6119)) - Implement the `/_matrix/federation/unstable/net.atleastfornow/state/<context>` API as drafted in MSC2314. ([\#6176](#6176)) - Configure privacy-preserving settings by default for the room directory. ([\#6354](#6354)) - Add ephemeral messages support by partially implementing [MSC2228](matrix-org/matrix-spec-proposals#2228). ([\#6409](#6409)) - Add support for [MSC 2367](matrix-org/matrix-spec-proposals#2367), which allows specifying a reason on all membership events. ([\#6434](#6434)) Bugfixes -------- - Transfer non-standard power levels on room upgrade. ([\#6237](#6237)) - Fix error from the Pillow library when uploading RGBA images. ([\#6241](#6241)) - Correctly apply the event filter to the `state`, `events_before` and `events_after` fields in the response to `/context` requests. ([\#6329](#6329)) - Fix caching devices for remote users when using workers, so that we don't attempt to refetch (and potentially fail) each time a user requests devices. ([\#6332](#6332)) - Prevent account data syncs getting lost across TCP replication. ([\#6333](#6333)) - Fix bug: TypeError in `register_user()` while using LDAP auth module. ([\#6406](#6406)) - Fix an intermittent exception when handling read-receipts. ([\#6408](#6408)) - Fix broken guest registration when there are existing blocks of numeric user IDs. ([\#6420](#6420)) - Fix startup error when http proxy is defined. ([\#6421](#6421)) - Fix error when using synapse_port_db on a vanilla synapse db. ([\#6449](#6449)) - Fix uploading multiple cross signing signatures for the same user. ([\#6451](#6451)) - Fix bug which lead to exceptions being thrown in a loop when a cross-signed device is deleted. ([\#6462](#6462)) - Fix `synapse_port_db` not exiting with a 0 code if something went wrong during the port process. ([\#6470](#6470)) - Improve sanity-checking when receiving events over federation. ([\#6472](#6472)) - Fix inaccurate per-block Prometheus metrics. ([\#6491](#6491)) - Fix small performance regression for sending invites. ([\#6493](#6493)) - Back out cross-signing code added in Synapse 1.5.0, which caused a performance regression. ([\#6494](#6494)) Improved Documentation ---------------------- - Update documentation and variables in user contributed systemd reference file. ([\#6369](#6369), [\#6490](#6490)) - Fix link in the user directory documentation. ([\#6388](#6388)) - Add build instructions to the docker readme. ([\#6390](#6390)) - Switch Ubuntu package install recommendation to use python3 packages in INSTALL.md. ([\#6443](#6443)) - Write some docs for the quarantine_media api. ([\#6458](#6458)) - Convert CONTRIBUTING.rst to markdown (among other small fixes). ([\#6461](#6461)) Deprecations and Removals ------------------------- - Remove admin/v1/users_paginate endpoint. Contributed by Awesome Technologies Innovationslabor GmbH. ([\#5925](#5925)) - Remove fallback for federation with old servers which lack the /federation/v1/state_ids API. ([\#6488](#6488)) Internal Changes ---------------- - Add benchmarks for structured logging and improve output performance. ([\#6266](#6266)) - Improve the performance of outputting structured logging. ([\#6322](#6322)) - Refactor some code in the event authentication path for clarity. ([\#6343](#6343), [\#6468](#6468), [\#6480](#6480)) - Clean up some unnecessary quotation marks around the codebase. ([\#6362](#6362)) - Complain on startup instead of 500'ing during runtime when `public_baseurl` isn't set when necessary. ([\#6379](#6379)) - Add a test scenario to make sure room history purges don't break `/messages` in the future. ([\#6392](#6392)) - Clarifications for the email configuration settings. ([\#6423](#6423)) - Add more tests to the blacklist when running in worker mode. ([\#6429](#6429)) - Refactor data store layer to support multiple databases in the future. ([\#6454](#6454), [\#6464](#6464), [\#6469](#6469), [\#6487](#6487)) - Port synapse.rest.client.v1 to async/await. ([\#6482](#6482)) - Port synapse.rest.client.v2_alpha to async/await. ([\#6483](#6483)) - Port SyncHandler to async/await. ([\#6484](#6484))

Synapse 1.7.0 (2019-12-13) ========================== This release changes the default settings so that only local authenticated users can query the server's room directory. See the [upgrade notes](UPGRADE.rst#upgrading-to-v170) for details. Support for SQLite versions before 3.11 is now deprecated. A future release will refuse to start if used with an SQLite version before 3.11. Administrators are reminded that SQLite should not be used for production instances. Instructions for migrating to Postgres are available [here](docs/postgres.md). A future release of synapse will, by default, disable federation for servers using SQLite. No significant changes since 1.7.0rc2. Synapse 1.7.0rc2 (2019-12-11) ============================= Bugfixes -------- - Fix incorrect error message for invalid requests when setting user's avatar URL. ([\#6497](#6497)) - Fix support for SQLite 3.7. ([\#6499](#6499)) - Fix regression where sending email push would not work when using a pusher worker. ([\#6507](#6507), [\#6509](#6509)) Synapse 1.7.0rc1 (2019-12-09) ============================= Features -------- - Implement per-room message retention policies. ([\#5815](#5815), [\#6436](#6436)) - Add etag and count fields to key backup endpoints to help clients guess if there are new keys. ([\#5858](#5858)) - Add `/admin/v2/users` endpoint with pagination. Contributed by Awesome Technologies Innovationslabor GmbH. ([\#5925](#5925)) - Require User-Interactive Authentication for `/account/3pid/add`, meaning the user's password will be required to add a third-party ID to their account. ([\#6119](#6119)) - Implement the `/_matrix/federation/unstable/net.atleastfornow/state/<context>` API as drafted in MSC2314. ([\#6176](#6176)) - Configure privacy-preserving settings by default for the room directory. ([\#6355](#6355)) - Add ephemeral messages support by partially implementing [MSC2228](matrix-org/matrix-spec-proposals#2228). ([\#6409](#6409)) - Add support for [MSC 2367](matrix-org/matrix-spec-proposals#2367), which allows specifying a reason on all membership events. ([\#6434](#6434)) Bugfixes -------- - Transfer non-standard power levels on room upgrade. ([\#6237](#6237)) - Fix error from the Pillow library when uploading RGBA images. ([\#6241](#6241)) - Correctly apply the event filter to the `state`, `events_before` and `events_after` fields in the response to `/context` requests. ([\#6329](#6329)) - Fix caching devices for remote users when using workers, so that we don't attempt to refetch (and potentially fail) each time a user requests devices. ([\#6332](#6332)) - Prevent account data syncs getting lost across TCP replication. ([\#6333](#6333)) - Fix bug: TypeError in `register_user()` while using LDAP auth module. ([\#6406](#6406)) - Fix an intermittent exception when handling read-receipts. ([\#6408](#6408)) - Fix broken guest registration when there are existing blocks of numeric user IDs. ([\#6420](#6420)) - Fix startup error when http proxy is defined. ([\#6421](#6421)) - Fix error when using synapse_port_db on a vanilla synapse db. ([\#6449](#6449)) - Fix uploading multiple cross signing signatures for the same user. ([\#6451](#6451)) - Fix bug which lead to exceptions being thrown in a loop when a cross-signed device is deleted. ([\#6462](#6462)) - Fix `synapse_port_db` not exiting with a 0 code if something went wrong during the port process. ([\#6470](#6470)) - Improve sanity-checking when receiving events over federation. ([\#6472](#6472)) - Fix inaccurate per-block Prometheus metrics. ([\#6491](#6491)) - Fix small performance regression for sending invites. ([\#6493](#6493)) - Back out cross-signing code added in Synapse 1.5.0, which caused a performance regression. ([\#6494](#6494)) Improved Documentation ---------------------- - Update documentation and variables in user contributed systemd reference file. ([\#6369](#6369), [\#6490](#6490)) - Fix link in the user directory documentation. ([\#6388](#6388)) - Add build instructions to the docker readme. ([\#6390](#6390)) - Switch Ubuntu package install recommendation to use python3 packages in INSTALL.md. ([\#6443](#6443)) - Write some docs for the quarantine_media api. ([\#6458](#6458)) - Convert CONTRIBUTING.rst to markdown (among other small fixes). ([\#6461](#6461)) Deprecations and Removals ------------------------- - Remove admin/v1/users_paginate endpoint. Contributed by Awesome Technologies Innovationslabor GmbH. ([\#5925](#5925)) - Remove fallback for federation with old servers which lack the /federation/v1/state_ids API. ([\#6488](#6488)) Internal Changes ---------------- - Add benchmarks for structured logging and improve output performance. ([\#6266](#6266)) - Improve the performance of outputting structured logging. ([\#6322](#6322)) - Refactor some code in the event authentication path for clarity. ([\#6343](#6343), [\#6468](#6468), [\#6480](#6480)) - Clean up some unnecessary quotation marks around the codebase. ([\#6362](#6362)) - Complain on startup instead of 500'ing during runtime when `public_baseurl` isn't set when necessary. ([\#6379](#6379)) - Add a test scenario to make sure room history purges don't break `/messages` in the future. ([\#6392](#6392)) - Clarifications for the email configuration settings. ([\#6423](#6423)) - Add more tests to the blacklist when running in worker mode. ([\#6429](#6429)) - Refactor data store layer to support multiple databases in the future. ([\#6454](#6454), [\#6464](#6464), [\#6469](#6469), [\#6487](#6487)) - Port synapse.rest.client.v1 to async/await. ([\#6482](#6482)) - Port synapse.rest.client.v2_alpha to async/await. ([\#6483](#6483)) - Port SyncHandler to async/await. ([\#6484](#6484))

See matrix-org/matrix-spec-proposals#2367. Closes #370.

See matrix-org/matrix-spec-proposals#2367.

turt2live · 2020-06-04T13:47:34Z

We probably don't need a proof of concept implementation for this - moving into the spec writing queue.

turt2live · 2020-06-04T13:48:10Z

oh, it has been implemented but no one linked to it: matrix-org/synapse#6434

MSC: #2367

turt2live · 2020-09-30T19:46:28Z

Spec PR: #2795

turt2live · 2020-10-07T20:52:08Z

Merged 🎉

Implement MSC2367 (matrix-org/matrix-spec-proposals#2367), already supported by synapse: allow giving a reason when joining, leaving, inviting, and unbanning in addition to kicking and banning.

Using the join `reason` added in [MSC2367](matrix-org/matrix-spec-proposals#2367). Unfortunately, this PR doesn't have much effect because it doesn't look like many clients support it yet (Element doesn't support it for example). Part of #257

erikj/msc_membership_reasons

29745d0

erikjohnston force-pushed the erikj/invite_reject_reasons branch from fee1770 to 29745d0 Compare November 26, 2019 11:22

erikjohnston added the proposal A matrix spec change proposal label Nov 26, 2019

This was referenced Nov 26, 2019

Invite reason matrix-org/synapse#6417

Closed

Invite reject reason matrix-org/synapse#6416

Closed

ara4n reviewed Nov 26, 2019

View reviewed changes

proposals/2367-membership-reasons.md Show resolved Hide resolved

Add note about using PUT /state/m.room.member/

f054ffe

erikjohnston added the proposal-in-review label Nov 26, 2019

anoadragon453 approved these changes Nov 26, 2019

View reviewed changes

uhoreg reviewed Nov 26, 2019

View reviewed changes

turt2live approved these changes Nov 26, 2019

View reviewed changes

proposals/2367-membership-reasons.md Show resolved Hide resolved

mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge labels Nov 26, 2019

turt2live changed the title ~~MSC: Add reason field to all membership events~~ MSC2367: Add reason field to all membership events Nov 26, 2019

turt2live removed the proposal-in-review label Nov 26, 2019

erikjohnston mentioned this pull request Nov 26, 2019

Ability to add additional metadata to invites #2339

Closed

turt2live mentioned this pull request Nov 26, 2019

MSC1983: Supporting a reason for leaving rooms #1983

Merged

mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Nov 27, 2019

erikjohnston mentioned this pull request Nov 28, 2019

Implement MSC 2367 - Membership Reasons matrix-org/synapse#6434

Merged

mscbot added the finished-final-comment-period label Dec 2, 2019

mscbot removed the final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. label Dec 2, 2019

turt2live merged commit e4deb4c into master Dec 2, 2019

bmarty added a commit to element-hq/element-android that referenced this pull request Dec 4, 2019

Add reason for all membership events (matrix-org/matrix-spec-proposal…

6a762fd

…s#2367)

bmarty mentioned this pull request Dec 4, 2019

Displaay ban and other membership events reason element-hq/element-android#738

Merged

bmarty added a commit to element-hq/element-android that referenced this pull request Dec 5, 2019

Add reason for all membership events (matrix-org/matrix-spec-proposal…

bbe59e3

…s#2367)

bmarty added a commit to element-hq/element-android that referenced this pull request Dec 9, 2019

Add reason for all membership events (matrix-org/matrix-spec-proposal…

d28700e

…s#2367)

KitsuneRal mentioned this pull request Dec 24, 2019

Add reason to member events quotient-im/libQuotient#370

Closed

KitsuneRal added a commit to quotient-im/libQuotient that referenced this pull request Dec 25, 2019

RoomMemberEvent: introduce the reason field (MSC2367)

0373153

See matrix-org/matrix-spec-proposals#2367. Closes #370.

KitsuneRal added a commit to quotient-im/Quaternion that referenced this pull request Mar 15, 2020

MessageEventModel::data(): use the reason field for all member events

8e41053

See matrix-org/matrix-spec-proposals#2367.

turt2live added the kind:feature MSC for not-core and not-maintenance stuff label Apr 20, 2020

turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Jun 4, 2020

joepie91 mentioned this pull request Aug 12, 2020

m.room.member$kick and m.room.member$ban examples should have a reason #2161

Closed

turt2live self-assigned this Sep 30, 2020

turt2live added a commit that referenced this pull request Sep 30, 2020

Add membership reasons to the spec for all membership events

2d047e3

MSC: #2367

turt2live mentioned this pull request Sep 30, 2020

Add membership reasons to the spec for all membership events #2795

Merged

turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Sep 30, 2020

turt2live added merged A proposal whose PR has merged into the spec! and removed disposition-merge spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Oct 7, 2020

aaronraimist mentioned this pull request Jan 28, 2021

Require confirmation to start a direct message from right panel element-hq/element-web#16300

Closed

zecakeh mentioned this pull request Feb 24, 2022

Member event needs a reason ruma/ruma#41

Closed

MadLittleMods mentioned this pull request Jun 6, 2023

Add reason why the archive bot is joining the room matrix-org/matrix-viewer#262

Merged

S7evinK mentioned this pull request Sep 28, 2023

Declare support for Matrix 1.1 matrix-org/dendrite#3216

Open

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MSC2367: Add reason field to all membership events #2367

MSC2367: Add reason field to all membership events #2367

erikjohnston commented Nov 26, 2019 •

edited by turt2live

Loading

anoadragon453 left a comment

uhoreg Nov 26, 2019

erikjohnston Nov 26, 2019

turt2live left a comment

erikjohnston commented Nov 26, 2019

mscbot commented Nov 26, 2019 •

edited by richvdh

Loading

mscbot commented Nov 27, 2019

mscbot commented Dec 2, 2019

bmarty commented Dec 6, 2019

turt2live commented Jun 4, 2020

turt2live commented Jun 4, 2020

turt2live commented Sep 30, 2020

turt2live commented Oct 7, 2020


		### Leaving a Room

		A user may wish to leave a room e.g. because the room is no longer relevant

MSC2367: Add reason field to all membership events #2367

MSC2367: Add reason field to all membership events #2367

Conversation

erikjohnston commented Nov 26, 2019 • edited by turt2live Loading

anoadragon453 left a comment

Choose a reason for hiding this comment

uhoreg Nov 26, 2019

Choose a reason for hiding this comment

erikjohnston Nov 26, 2019

Choose a reason for hiding this comment

turt2live left a comment

Choose a reason for hiding this comment

erikjohnston commented Nov 26, 2019

mscbot commented Nov 26, 2019 • edited by richvdh Loading

mscbot commented Nov 27, 2019

mscbot commented Dec 2, 2019

bmarty commented Dec 6, 2019

turt2live commented Jun 4, 2020

turt2live commented Jun 4, 2020

turt2live commented Sep 30, 2020

turt2live commented Oct 7, 2020

erikjohnston commented Nov 26, 2019 •

edited by turt2live

Loading

mscbot commented Nov 26, 2019 •

edited by richvdh

Loading