-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC2326: Label based filtering #2326
Open
ara4n
wants to merge
22
commits into
old_master
Choose a base branch
from
matthew/msc2326
base: old_master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
3214e90
MSC2326: Label based filtering
ara4n 8c84d7b
Add links to other MSCs
babolivier cb0c68f
Incorporate reviews
babolivier 6627b00
Describe alternative solutions
babolivier 32597a7
Include an unstable prefix for m.labels_hashes
babolivier 6f36f56
Incorporate review
babolivier 46d412e
Fix link
babolivier 78c4e16
Fix copy-paste
babolivier 05217cd
Standardise labels format
babolivier da7776f
Mandate case insensitivity in labels
babolivier 158f11a
Update unstable feature flag with vendor prefix
babolivier 3a8f716
Add security considerations
babolivier b080337
Merge branch 'matthew/msc2326' of github.com:matrix-org/matrix-doc in…
babolivier 61f1396
Incorporate review
babolivier d1110a2
Extend the filtering to every endpoint supporting it
babolivier 45225af
Specify a maximum length for labels
babolivier f325203
Specify interaction with edits
babolivier a6d1249
Fix editing on encrypted events
babolivier a3450a6
Add some clarification about edits
babolivier 7a21efd
Spell out that hashtag-like labels can have any character in them
babolivier 4b7ca52
Specify how client UIs are supposed to behave
babolivier 88c93dc
Merge branch 'matthew/msc2326' of github.com:matrix-org/matrix-doc in…
babolivier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just rereading this proposal, I think @dkasak's points on the main thread are legitimate: that hashing the labels give a very false sense of security here. Given how strong our e2ee is, folks will assume opaque labels are actually encrypted, rather than just obfuscated by a hash which can be easily rainbow-tabled.
Personally, I think it'd be fine to add a pepper to the hashed events, and require at the application level that for labels to work in encrypted rooms, the new user must be brought up to speed on the pepper (e.g. by the inviter sharing the pepper in an encrypted message, possibly to-device, after having invited them).
This is simpler than using opaque IDs for the unencrypted event headers, as there's only one pepper that needs to be shared to new users, rather than the whole set of opaque->real label mappings.