remove login fallback #1105
Closed
remove login fallback #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to remove the static client from synapse the spec should not state that the server brings a client.
|
I don't think we can get rid of login fallback, I'm afraid. |
|
What is the reason to keep it? |
|
This is nothing to do with the angular client that synapse currently hosts. Home servers provide a fallback login mechanism for clients that don't support one or more or the login types that synapse advertises. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to remove the static client from synapse the spec should
not state that the server brings a client.
Signed-Off-by: Matthias Kesler krombel@krombel.de