Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp massaging for application services #1585

Closed
turt2live opened this issue Aug 28, 2018 · 6 comments
Closed

Timestamp massaging for application services #1585

turt2live opened this issue Aug 28, 2018 · 6 comments
Labels
application services feature Suggestion for a significant extension which needs considerable consideration

Comments

@turt2live
Copy link
Member

This needs a bit of thought before it can safely be in the spec. The intention behind timestamp massaging is that appservices can bridge in old history for a network into matrix seamlessly. The ?ts param is meant to apply to every endpoint that sends an event, such as /send, /ban, and /createRoom. the last one in that list, /createRoom, causes some problems though: the ?ts param seems too blunt to apply to all of the events in the request.

In addition, the section needs some work in terms of wording to reference that the ?ts param does not affect DAG ordering.

For reference, here's the original section: https://github.com/matrix-org/matrix-doc/blob/17e0ef4b91034b0cdb010416225ffac65b4107fc/specification/application_service_api.rst#232timestamp-massaging

@turt2live turt2live added the feature Suggestion for a significant extension which needs considerable consideration label Aug 28, 2018
turt2live added a commit to turt2live/matrix-doc that referenced this issue Aug 28, 2018
@turt2live
Copy link
Member Author

See also: #1394 (closed in favour of this)

@turt2live
Copy link
Member Author

@martindale
Copy link

What's the current path to leveraging this feature?

@turt2live
Copy link
Member Author

turt2live commented May 2, 2019

Synapse implements it and is considered an easter egg. A proper proposal is needed to have it land in the spec due to the concerns outlined here.

@Half-Shot
Copy link
Contributor

Possibly not a duplicate of matrix-org/matrix-spec#193, as that issue is explictly about lazy backfilling history (solved via another feature/proposal). This issue is about setting a timestamp for events being sent into a room live (e.g. I want to set the true timestamp of an event arriving over the bridge). As such, this should probably be reopened @turt2live.

As it stands, #3316 is aiming to solve this.

@turt2live
Copy link
Member Author

I'm not really understanding the nuance there, but it sounds like it's covered by MSCs so this doesn't need to be open.

RiotTranslateBot pushed a commit to RiotTranslateBot/matrix-doc that referenced this issue Aug 22, 2023
* Remove unnecessary `oneOf`s in JSON schemas

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>

* Add changelog

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>

---------

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application services feature Suggestion for a significant extension which needs considerable consideration
Projects
None yet
Development

No branches or pull requests

3 participants