Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(appservice): Cache namespace regexes #750

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

agraven
Copy link
Contributor

@agraven agraven commented Jun 10, 2022

I wasn't entirely sure where the best place to put the cached regexes were.

@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #750 (adc623c) into main (253affe) will increase coverage by 0.00%.
The diff coverage is 80.00%.

@@           Coverage Diff           @@
##             main     #750   +/-   ##
=======================================
  Coverage   71.54%   71.54%           
=======================================
  Files         118      118           
  Lines       16487    16495    +8     
=======================================
+ Hits        11796    11802    +6     
- Misses       4691     4693    +2     
Impacted Files Coverage Δ
crates/matrix-sdk-appservice/src/lib.rs 66.03% <80.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 253affe...adc623c. Read the comment docs.

Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible.

@poljar poljar merged commit 251a382 into matrix-org:main Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants