Skip to content

Conversation

@gnunicorn
Copy link
Contributor

No description provided.

@gnunicorn gnunicorn enabled auto-merge May 11, 2022 17:05
@jplatte
Copy link
Collaborator

jplatte commented May 11, 2022

As I commented in #664, let's also change the fallback if the sender field isn't found to doing the push rule check, rather than skipping it. (map_or(true, ..) instead of map_or(false, ..))

@gnunicorn gnunicorn mentioned this pull request May 11, 2022
6 tasks
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #667 (70c0626) into main (5570181) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #667   +/-   ##
=======================================
  Coverage   73.49%   73.49%           
=======================================
  Files         101      101           
  Lines       15132    15132           
=======================================
  Hits        11121    11121           
  Misses       4011     4011           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5570181...70c0626. Read the comment docs.

@gnunicorn gnunicorn merged commit 4c84f25 into main May 11, 2022
@gnunicorn gnunicorn deleted the ben-releasing-base-0.5.1 branch May 11, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants