Skip to content

Conversation

@zecakeh
Copy link
Collaborator

@zecakeh zecakeh commented Nov 28, 2025

The supported versions are necessary for querying almost all endpoints, but after homeserver auto-discovery the well-known info is only,necessary to get the MatrixRTC foci advertised by the homeserver. So it shouldn't be necessary to always request both at the same time.

Besides:

This can be reviewed commit by commit, although most of the change happens in one of them.

This seems to come from a previous commit?

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
To make it reusable.

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@zecakeh zecakeh requested a review from a team as a code owner November 28, 2025 11:49
@zecakeh zecakeh requested review from andybalaam and removed request for a team November 28, 2025 11:49
@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

❌ Patch coverage is 86.19403% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.65%. Comparing base (73449f4) to head (a6ade9c).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/matrix-sdk/src/client/mod.rs 84.43% 12 Missing and 14 partials ⚠️
...tes/matrix-sdk-base/src/store/integration_tests.rs 86.00% 0 Missing and 7 partials ⚠️
crates/matrix-sdk-base/src/store/traits.rs 94.11% 0 Missing and 2 partials ⚠️
crates/matrix-sdk-sqlite/src/state_store.rs 50.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5910      +/-   ##
==========================================
- Coverage   88.66%   88.65%   -0.02%     
==========================================
  Files         362      363       +1     
  Lines      104399   104490      +91     
  Branches   104399   104490      +91     
==========================================
+ Hits        92569    92637      +68     
- Misses       7499     7507       +8     
- Partials     4331     4346      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 28, 2025

CodSpeed Performance Report

Merging #5910 will not alter performance

Comparing zecakeh:split-well-known (a6ade9c) with main (73449f4)

Summary

✅ 50 untouched

The supported versions are necessary for querying almost all endpoints,
but after homeserver auto-discovery the well-known info is only
necessary to get the MatrixRTC foci advertised by the homeserver. So it
shouldn't be necessary to always request both at the same time.

Besides:

- Not all clients support MatrixRTC, so they don't need the well-known
  info.
- The well-known info is only supposed to be used for homeserver
  auto-discovery before login. In fact, the MatrixRTC MSC was changed to
  use a new endpoint for this.
- We don't have access to the server name after restoring the Client, so
  the well-known lookup is more likely to fail.

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant