refactor(test): Extract common crypto mock server helper #5005
+611
−573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillCarsonFr
changed the base branch from
main
to
valere/crypto/to_device_encrypt_helper
1 task
poljar
requested changes
May 7, 2025
Comment on lines
+92
to
+101
| pub struct MatrixKeysMockServer { | ||
| /// The underlying [`wiremock`] [`MockServer`] | ||
| pub server: MockServer, | ||
| keys: Arc<Mutex<Keys>>, | ||
| token_to_user_id_map: Arc<Mutex<BTreeMap<String, OwnedUserId>>>, | ||
| token_counter: AtomicU32, | ||
| } |
There was a problem hiding this comment.
This doesn't really incorporate the Keys struct into MatrixMockServer instead it creates another mock server concept with much less functionality.
I don't think we'd want to have two of those.
BillCarsonFr
force-pushed
the
valere/crypto/extract_crypto_mockserver_helper
branch
from
50829d3 to
cf13d30
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5005 +/- ##
==========================================
- Coverage 85.82% 85.73% -0.10%
==========================================
Files 325 326 +1
Lines 35984 36196 +212
==========================================
+ Hits 30883 31032 +149
- Misses 5101 5164 +63 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft because it is a follow up of #4998
Extracted a helper to create a wiremock server that allows to perform full end to end encryption tests.
Note: In the existing verification test there was a
known_deviceslist, but this was not used (the test work fine if you remove it), so I removed it when extracting the mock helpersSigned-off-by: