Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffi: Allow recovery to be enabled using a passphrase #4037

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

poljar
Copy link
Contributor

@poljar poljar commented Sep 26, 2024

Some people might want to use the recovery module using a passphrase, please note EX should just pass None as the passphrase argument.

@poljar poljar requested a review from a team as a code owner September 26, 2024 13:57
@poljar poljar requested review from jmartinesp and removed request for a team September 26, 2024 13:57
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.49%. Comparing base (322c5b3) to head (e7cbc30).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4037      +/-   ##
==========================================
- Coverage   84.50%   84.49%   -0.02%     
==========================================
  Files         266      266              
  Lines       28475    28475              
==========================================
- Hits        24062    24059       -3     
- Misses       4413     4416       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poljar poljar merged commit e61fb45 into main Sep 27, 2024
40 checks passed
@poljar poljar deleted the poljar/expose-passphrase-based-recovery-over-ffi branch September 27, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants