Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing of QR codes from MSC4108 #3387

Merged
merged 2 commits into from
May 14, 2024
Merged

Parsing of QR codes from MSC4108 #3387

merged 2 commits into from
May 14, 2024

Conversation

poljar
Copy link
Contributor

@poljar poljar commented May 8, 2024

This is the first part of MSC4108 support, it just adds the basic parsing and encoding parts for the data which will be present in QR codes for MSC4108.

  • Public API changes documented in changelogs (optional)

@poljar poljar requested a review from a team as a code owner May 8, 2024 11:23
@poljar poljar requested review from Hywan and removed request for a team May 8, 2024 11:23
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 82.99%. Comparing base (da249bb) to head (55fb4fe).

Files Patch % Lines
crates/matrix-sdk-crypto/src/types/qr_login.rs 94.11% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3387      +/-   ##
==========================================
+ Coverage   82.96%   82.99%   +0.03%     
==========================================
  Files         245      246       +1     
  Lines       24907    24958      +51     
==========================================
+ Hits        20665    20715      +50     
- Misses       4242     4243       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@poljar poljar enabled auto-merge (rebase) May 14, 2024 08:36
@poljar poljar merged commit aa6bbc1 into main May 14, 2024
35 checks passed
@poljar poljar deleted the poljar/qr-login-parsing branch May 14, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants