Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide
CryptoStore::mark_inbound_group_sessions_as_backed_up
on stores and use it inBackupMachine::mark_request_as_sent
#2934Provide
CryptoStore::mark_inbound_group_sessions_as_backed_up
on stores and use it inBackupMachine::mark_request_as_sent
#2934Changes from all commits
4ebb8e2
f879f3d
794b7ea
9e67b6f
03aad4e
dfb33c9
512509c
a032d33
0cf99db
f3101ba
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hywan I've attempted to refactor it to use
chunk_large_query_over
- what do you think?I couldn't find a way to do it in one transaction - I'm not sure whether that's needed or not.
I think I would need to add a new
with_transaction_sync
and that would need a newinteract_async
- do you agree?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussing with @richvdh and @BillCarsonFr we think not having it all in a single transaction is OK.