Groundwork for fixes to one-time-key fetching #2803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Account::create_outbound_session` no longer takes an entire list of keys; rather it takes a single key and it is up to the caller to pick a key out of the list. This in turn means that `SessionCreationError` loses one of its reason codes.
... and use it in some tests. Simplify some of the test code by not building a whole keys/claim response.
it's a bit pointless.
richvdh
force-pushed
the
rav/claim_keys_prep
branch
from
d832575
to
e408ffd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2803 +/- ##
==========================================
+ Coverage 81.39% 81.73% +0.33%
==========================================
Files 204 204
Lines 20998 21008 +10
==========================================
+ Hits 17092 17171 +79
+ Misses 3906 3837 -69
☔ View full report in Codecov by Sentry. |
poljar
reviewed
Nov 2, 2023
poljar
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some non-functional refactoring in preparation for fixing #281. Suggest review commit-by-commit. The salient changes are:
Account::create_outbound_sessionno longer takes an entire list of keys; rather it takes a single key and it is up to the caller to pick a key out of the list. This in turn means thatSessionCreationErrorloses one of its reason codes.SessionManager::create_sessionsis factored out ofreceive_keys_claim_response. This is mostly helpful in tests, where our goal is to establish a session with a given device, rather than actually to test parsing of the entire/keys/claimresponse.