appservice: Add join_room_by_id(_or_alias) #280
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an appservice-specific way of joining rooms that makes sure room state is synced once (via the room
/state
C2S API) before the method returns so that we have a valid state before proceeding.This still feels a bit brittle, it might actually make more sense to have a low-level functionality that checks for proper room state, that could also cover the case of syncing state for rooms that are already joined but state store was not persisted, which the regular
Client
does cover throughsync
* methods when there was no sync before the first one. But it should be OK for a first iteration and having the tests for it makes sense anyway.Part of #228