crypto: Fuse ReadOnlyAccount and Account ✨

[bnjbvr]

This started as "oh it looks like I can avoid using Account here and there" until there was only a single meaningful use in OlmMachine. But what is an Account, other than a ReadOnlyAccount with extra capabilities and access to a store? By passing the store as a parameter to most Account methods, those methods could be moved to the ReadOnlyAccount, resulting in their merging \o/

Then I could rename ReadOnlyAccount to Account. The universe is a bit more in order.

This can be reviewed commit by commit.

Part of #2624.

[codecov]

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (6c9cfe1) 78.18% compared to head (71861d9) 78.16%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2680      +/-   ##
==========================================
- Coverage   78.18%   78.16%   -0.03%     
==========================================
  Files         191      191              
  Lines       19851    19831      -20     
==========================================
- Hits        15521    15501      -20     
  Misses       4330     4330              

Files	Coverage Δ
crates/matrix-sdk-crypto/src/dehydrated_devices.rs	100.00% <100.00%> (ø)
crates/matrix-sdk-crypto/src/gossiping/machine.rs	65.26% <100.00%> (ø)
crates/matrix-sdk-crypto/src/identities/device.rs	75.48% <100.00%> (ø)
crates/matrix-sdk-crypto/src/identities/manager.rs	81.94% <100.00%> (-0.25%)	⬇️
crates/matrix-sdk-crypto/src/identities/user.rs	86.54% <ø> (ø)
crates/matrix-sdk-crypto/src/lib.rs	100.00% <ø> (ø)
crates/matrix-sdk-crypto/src/machine.rs	83.24% <100.00%> (-0.40%)	⬇️
...atrix-sdk-crypto/src/olm/group_sessions/inbound.rs	82.42% <ø> (ø)
...trix-sdk-crypto/src/olm/group_sessions/outbound.rs	93.51% <ø> (ø)
crates/matrix-sdk-crypto/src/olm/signing/mod.rs	88.72% <ø> (ø)
... and 13 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[poljar]

Thanks for splitting this out. Was reasonably pleasant to review because of this. Another thanks for realizing that we don't need both of them anymore. 🎉