Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appservice: Refactor API #231

Merged
merged 1 commit into from
May 14, 2021
Merged

appservice: Refactor API #231

merged 1 commit into from
May 14, 2021

Conversation

johannescpk
Copy link
Contributor

@johannescpk johannescpk commented May 12, 2021 •
edited
Loading

Refactors APIs and improves documentation

  • Merged client and client_with_localpart
  • client no longer implicitly calls register
  • Renamed hs_token_matches to compare_hs_token
  • Exposed ensure_registered as register
  • Moved get_host_and_port_from_registration to AppserviceRegistration::get_host_and_port
  • Added set_event_handler convenience wrapper

Tracking issue: #228

@johannescpk johannescpk marked this pull request as ready for review May 12, 2021 18:22
@johannescpk johannescpk mentioned this pull request May 12, 2021
Closed
40 tasks
poljar
poljar approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks for splitting this up into small consumable PRs.

Sadly there are some merge conflicts after the rustfmt PR merge, once those are resolved we can merge.

@johannescpk johannescpk force-pushed the refactor/appservice-api branch 2 times, most recently from 70515b4 to 69710d6 Compare May 13, 2021 15:37
@johannescpk
Copy link
Contributor Author

Thanks for the fast reviews!

Rebased and rustfmt'ed accordingly.

@poljar poljar merged commit 0bdcc0f into matrix-org:master May 14, 2021
@poljar
Copy link
Contributor

poljar commented May 14, 2021 •
edited
Loading

Thanks, merged.

@johannescpk johannescpk deleted the refactor/appservice-api branch May 14, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poljar poljar poljar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johannescpk @poljar