Build Node bindings against Ubuntu 20.04

[AndrewFerr]

Should fix #1808

• Public API changes documented in changelogs (optional)

Signed-off-by: Andrew Ferrazzutti andrewf@element.io

[AndrewFerr]

Ah, this conflicts with main since the Node bindings release workflow PR was reverted. Maybe we could resolve both the linux-musl build issue & the glibc compatibility issue all in one shot here?

[AndrewFerr]

By the way, I've confirmed that using this release lets me run matrix-appservice-bridge's tests (after having added a dependency on the crypto bindings) in a local Docker container of ubuntu:20.04, whereas using the prior beta release hits the same glibc error as seen in CI workflows (example).

[Hywan]

Can you explain as a YAML comment why we aren't using ubuntu-latest please? It will help to keep the knowledge in the appropriate place.

[Hywan]

Ah, this conflicts with main since the Node bindings release workflow PR was reverted. Maybe we could resolve both the linux-musl build issue & the glibc compatibility issue all in one shot here?

I'm OK to resolve both at the same time here.

[AndrewFerr]

Can you explain as a YAML comment why we aren't using ubuntu-latest please? It will help to keep the knowledge in the appropriate place.

Done via 4bf6ce0.

I'm OK to resolve both at the same time here.

From what I can tell from the logs for running the prerelease workflow on this commit, there were no issues with any of the prebuilt libraries, even those for linux-musl. Is there anything else that needs to be done to fix the release process?

[AndrewFerr]

I'll rebase this on the latest tip of main to see if the release workflow works with it (but will cancel before a release is published)

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (51a2d10) 75.96% compared to head (4bbea71) 75.94%.

❗ Current head 4bbea71 differs from pull request most recent head 8e05599. Consider uploading reports for the commit 8e05599 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1819      +/-   ##
==========================================
- Coverage   75.96%   75.94%   -0.02%     
==========================================
  Files         139      139              
  Lines       15300    15300              
==========================================
- Hits        11622    11620       -2     
- Misses       3678     3680       +2     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[AndrewFerr]

Ah, rebasing allowed CI to run & reveal build issues. I'll look into it

EDIT: false negative; it was just an outdated cache pulling in some glibc-incompatible dependencies. Deleting the cache fixed it.

[AndrewFerr]

As expected, the release workflow failed on the linux-musl build: https://github.com/matrix-org/matrix-rust-sdk/actions/runs/4808018200/jobs/8557495133

I'll try again with my PR re-applied to confirm whether or not it works.

[AndrewFerr]

Alright, restoring the linux-musl workflow change does let the release get built: https://github.com/matrix-org/matrix-rust-sdk/actions/runs/4808312230 (I cancelled the npm publish step to not publish it before we're okay with it.)

It looks like everything is fine with this; is there something missing?