Add FailedToParse timeline items #1224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 tasks
Codecov ReportBase: 74.41% // Head: 74.42% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1224 +/- ##
=======================================
Coverage 74.41% 74.42%
=======================================
Files 112 113 +1
Lines 12869 12952 +83
=======================================
+ Hits 9577 9639 +62
- Misses 3292 3313 +21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jplatte
force-pushed
the
jplatte/timeline-failed-to-parse
branch
from
367b025 to
c58d3b0
Compare
jplatte
force-pushed
the
jplatte/timeline-failed-to-parse
branch
from
c58d3b0 to
1b5b3b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a timeline event comes in but we fail to deserialize it, previously we would just ignore it. Now, if we can still parse everything except the content, we add an
EventTimelineItemwith a new kind of content so the fact an event arrived isn't just silently discarded. The raw event and error can be reflected in the UI somehow. If something outsidecontentfails to parse, that is either a bug in the server or in our code and we just log an error.The first case can easily happen by having a buggy or malicious client, so I think it's important we preserve as much information as possible. In the latter case, just logging an error should be fine as it's much less likely (requires a bug in the server, ruma or the SDK).