This repository was archived by the owner on Sep 27, 2024. It is now read-only.
Fix CTRL+Backspace behaviour on Windows #751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #751 +/- ##
==========================================
- Coverage 90.20% 89.95% -0.25%
==========================================
Files 111 82 -29
Lines 16115 14674 -1441
Branches 565 0 -565
==========================================
- Hits 14536 13200 -1336
+ Misses 1558 1474 -84
+ Partials 21 0 -21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
germain-gg
changed the title
florianduros
approved these changes
Jul 26, 2023
Contributor
florianduros
left a comment
florianduros
left a comment
There was a problem hiding this comment.
Looks good, minor suggestions
|
Kudos, SonarCloud Quality Gate passed! |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/vector-im/verticals-internal/issues/102
Add an operating system detection function based on the user agent. And processes input events differently based on the user OS.