Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Improve live voice broadcast detection by testing if the started event has been redacted #9780

Merged
weeman1337 merged 12 commits into from
Dec 22, 2022
Merged

Improve live voice broadcast detection by testing if the started event has been redacted #9780

weeman1337 merged 12 commits into from
Dec 22, 2022

Conversation

@weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Dec 15, 2022 •
edited
Loading

closes element-hq/element-web#24019
closes element-hq/element-web#24049

PSF-1781 PSF-1786

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Dec 15, 2022
@weeman1337 weeman1337 force-pushed the weeman1337/broadcast-live-detection branch from 5ebc1b5 to 77a392e Compare December 15, 2022 16:04
@weeman1337 weeman1337 changed the title Weeman1337/broadcast live detection Improve live voice broadcast detection by testing if the started event has been redacted Dec 16, 2022
@weeman1337
Add asyncEvery array util
2f715f3 
Signed-off-by: Michael Weimann <michaelw@matrix.org>
@weeman1337
Improve live broadcast detection
be40714
@weeman1337 weeman1337 force-pushed the weeman1337/broadcast-live-detection branch from 77a392e to be40714 Compare December 16, 2022 09:12
@weeman1337 weeman1337 marked this pull request as ready for review December 16, 2022 10:10
@weeman1337 weeman1337 requested a review from a team as a code owner December 16, 2022 10:10
florianduros
florianduros approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@florianduros florianduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor questions :)

@weeman1337 weeman1337 enabled auto-merge (squash) December 22, 2022 09:32
@weeman1337 weeman1337 merged commit b81582d into develop Dec 22, 2022
@weeman1337 weeman1337 deleted the weeman1337/broadcast-live-detection branch December 22, 2022 10:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kerryarchibald kerryarchibald Awaiting requested review from kerryarchibald kerryarchibald is a code owner automatically assigned from matrix-org/element-web-reviewers

@justjanne justjanne Awaiting requested review from justjanne justjanne is a code owner automatically assigned from matrix-org/element-web-reviewers

1 more reviewer

@florianduros florianduros florianduros approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fail to start playing a live voice broadcast from the PIP widget Unexpected live voice broadcast

3 participants

@weeman1337 @florianduros