Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Implement broadcast message preview #9762

Merged
merged 8 commits into from
Dec 16, 2022

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Dec 14, 2022

Part of element-hq/element-web#23282

Should be reviewed commit-wise. Contains some refactoring to solve cyclic dependencies.

image

Additionally hide message chunks

PSF-1712

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

Copy link
Contributor

@kerryarchibald kerryarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nitpick, otherwise LGTM

src/stores/room-list/previews/MessageEventPreview.ts Outdated Show resolved Hide resolved
@weeman1337 weeman1337 enabled auto-merge (squash) December 16, 2022 10:55
@weeman1337 weeman1337 merged commit 5155439 into develop Dec 16, 2022
@weeman1337 weeman1337 deleted the weeman1337/broadcast-message-preview branch December 16, 2022 11:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants