This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Minor code quality updates for ScrollPanel #9639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and removal of unused function `scrollRelative` in MessagePanel (discovered when changing the scrollRelative types in ScrollPanel). Changes: * Clean up logging a bit, make it clearer * Remove dead code * Add extra types for tsc --strict compliance (not complete) * Fix IDE warnings around spelling and missing awaits/promise return values * Modernize usage of logging
turt2live
added
the
T-Task
|
Coverage will be handled by element-hq/element-web#23531 |
SimonBrandner
approved these changes
Nov 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and removal of unused function
scrollRelativein MessagePanel (discovered when changing the scrollRelative types in ScrollPanel).Changes:
Auto-merge is enabled
This change is marked as an internal change (Task), so will not be included in the changelog.