Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

@toger5
Copy link
Contributor

@toger5 toger5 commented Nov 28, 2022

Signed-off-by: Timo K timok@element.io

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This is needed for: element-hq/element-call#767


This change is marked as an internal change (Task), so will not be included in the changelog.

@toger5 toger5 force-pushed the posthog-widget-embedding branch from 2d3626f to 18af716 Compare December 14, 2022 19:22
@toger5 toger5 marked this pull request as ready for review December 16, 2022 12:09
@toger5 toger5 requested a review from a team as a code owner December 16, 2022 12:09
@toger5
Copy link
Contributor Author

toger5 commented Dec 16, 2022

Do those changes require a test?

@toger5
Copy link
Contributor Author

toger5 commented Dec 21, 2022

Do those changes require a test?

We Internally decided, we want test for it. They are now added.

Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go otherwise

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants