Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Honor advanced audio processing settings when recording voice messages #9610

Merged
merged 8 commits into from
Dec 5, 2022
Merged

Honor advanced audio processing settings when recording voice messages #9610

merged 8 commits into from
Dec 5, 2022

Commits on Nov 27, 2022

  1. VoiceRecordings: honor advanced audio processing settings 

    Audio processing settings introduced in matrix-org#8759 is now taken into account
when recording a voice message.

Signed-off-by: László Várady <laszlo.varady@protonmail.com>
    @MrAnno
    MrAnno committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    d1369d4 View commit details
    Browse the repository at this point in the history

  2. VoiceRecordings: add higher-quality audio recording 

    When recording non-voice audio (e.g. music, FX), a different Opus encoder
application should be specified. It is also recommended to increase the
bitrate to 64-96 kb/s for musical use.

Note: the HQ mode is currently activated when noise suppression is
turned off. This is a very arbitrary condition.

Signed-off-by: László Várady <laszlo.varady@protonmail.com>
    @MrAnno
    MrAnno committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    b37174a View commit details
    Browse the repository at this point in the history

  3. RecorderWorklet: fix type mismatch 

    src/audio/VoiceRecording.ts:129:67 - Argument of type 'null' is not
assignable to parameter of type 'string | URL'.

Signed-off-by: László Várady <laszlo.varady@protonmail.com>
    @MrAnno
    MrAnno committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    38fb60c View commit details
    Browse the repository at this point in the history

  4. VoiceRecording: test audio settings 

    Signed-off-by: László Várady <laszlo.varady@protonmail.com>
    @MrAnno
    MrAnno committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    d3b6064 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2022

  1. Merge remote-tracking branch 'origin/develop' into voice-recorder-aud… 

    …io-processing-settings
    @MrAnno
    MrAnno committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    66e7353 View commit details
    Browse the repository at this point in the history

  2. Fix typos 

    Signed-off-by: László Várady <laszlo.varady@protonmail.com>
    @MrAnno
    MrAnno committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    6de5794 View commit details
    Browse the repository at this point in the history

  3. VoiceRecording: refactor using destructuring assignment 

    Signed-off-by: László Várady <laszlo.varady@protonmail.com>
    @MrAnno
    MrAnno committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    9a12cfb View commit details
    Browse the repository at this point in the history

  4. VoiceRecording: add comments about constants and non-trivial conditions 

    Signed-off-by: László Várady <laszlo.varady@protonmail.com>
    @MrAnno
    MrAnno committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    c389aa9 View commit details
    Browse the repository at this point in the history