Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

@florianduros
Copy link
Contributor

@florianduros florianduros commented Nov 14, 2022

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Removed the mock for useWysiwyg. During the first implementation here, issues with the wasm in the jest env forced to mock the hook.

  • The Response object is undefined in the jest env and make the wasm download failed.
  • With the hook properly working, I refined some tests to make them more reliable.

This change is marked as an internal change (Task), so will not be included in the changelog.

@florianduros florianduros changed the title remove useWysiwyg mock Remove useWysiwyg mock Nov 14, 2022
@florianduros florianduros added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Nov 14, 2022
@florianduros florianduros enabled auto-merge (squash) November 16, 2022 15:15
@florianduros florianduros merged commit 3243d21 into develop Nov 16, 2022
@florianduros florianduros deleted the tech/remove-use-wysiwyg-mock branch November 16, 2022 15:38
amywalkerdev pushed a commit that referenced this pull request Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants