This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Handle missing Element Call brand
#9376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
SimonBrandner
added
the
T-Defect
robintown
reviewed
Oct 7, 2022
Member
robintown
left a comment
robintown
left a comment
There was a problem hiding this comment.
We should update the SdkConfig types to reflect the fact that all the element_call subkeys are optional (and do the same for each subkey)
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
robintown
approved these changes
Oct 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes: none
Fixes #9347 (comment)
This change has no change notes, so will not be included in the changelog.