This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Device manager - add foundation for extended device info #9344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 29 commits
September 23, 2022 18:00
* add device selection that does nothing * multi select and sign out of sessions * test multiple selection * fix type after rebase * select all sessions
kerryarchibald
added
the
T-Task
weeman1337
suggested changes
Oct 4, 2022
Contributor
weeman1337
left a comment
weeman1337
left a comment
There was a problem hiding this comment.
Tested on the most recent deployment. The device manager explodes 💣 Can you have a look and then re-request review?
src/utils/device/parseUserAgent.ts
Outdated
| appBrand?: string, | ||
| ): DeviceType => { | ||
| // this sucks | ||
| const safeBrowserName = appBrand && browser.name.indexOf(appBrand) > -1 ? undefined : browser.name; |
Contributor
There was a problem hiding this comment.
😆 Is there anything that sucks less? You could use includes instead of the indexOf check btw..
kerryarchibald
force-pushed
the
psg-632/device-man-parse-ua
branch
from
e6bbc36 to
eef014a
Compare
Contributor
Author
|
@weeman1337 sorry, way too many nested branches open. Something weird happened while I rebased this and I included more changes than I meant to 🙈 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With matrix-org/matrix-js-sdk#2728
Mostly housekeeping:
ExtendedDevicetype everywhere in new DMclientName/VersiontoappName/Versionin types to avoid collision with UA parsed clientDeviceTypecomponent toDeviceTypeIconto avoid collisionChecklist
This change is marked as an internal change (Task), so will not be included in the changelog.