Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

@justjanne
Copy link
Contributor

@justjanne justjanne commented Sep 22, 2022

Type: Task
Fixes: element-hq/element-web#23155
Fixes: element-hq/element-web#23168


This change is marked as an internal change (Task), so will not be included in the changelog.

@justjanne justjanne added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Sep 22, 2022
@justjanne justjanne force-pushed the justjanne/task/spotlight-flaky-tests branch from 24efc84 to 6e63d22 Compare September 22, 2022 16:11
Copy link
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the test 👍

@justjanne justjanne force-pushed the justjanne/task/spotlight-flaky-tests branch from 3186195 to eb8cfeb Compare September 27, 2022 12:26
@justjanne justjanne marked this pull request as ready for review September 27, 2022 12:48
@justjanne justjanne requested a review from a team as a code owner September 27, 2022 12:48
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't looked, but approving to clear codeowners review (assuming @weeman1337's review is suitable)

@justjanne justjanne merged commit a704a2f into develop Sep 30, 2022
@justjanne justjanne deleted the justjanne/task/spotlight-flaky-tests branch September 30, 2022 08:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Spotlight" > "should find group DMs by usernames or user ids" is flaky "Spotlight" > "should show the same user only once" is flaky

4 participants