Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

@andybalaam
Copy link
Member

@andybalaam andybalaam commented Mar 15, 2022

(Still disabled for now)


This change is marked as an internal change (Task), so will not be included in the changelog.

Preview: https://pr8054--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@andybalaam andybalaam added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Mar 15, 2022
@andybalaam andybalaam requested a review from a team as a code owner March 15, 2022 09:24
@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #8054 (88cd6ea) into develop (2778fd1) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 88cd6ea differs from pull request most recent head 6122bdc. Consider uploading reports for the commit 6122bdc to get more accurate results

@@             Coverage Diff             @@
##           develop    #8054      +/-   ##
===========================================
- Coverage    26.82%   26.79%   -0.03%     
===========================================
  Files          866      866              
  Lines        51939    51947       +8     
  Branches     13159    13164       +5     
===========================================
- Hits         13931    13921      -10     
- Misses       38008    38026      +18     
Impacted Files Coverage Δ
...rc/components/views/location/LocationShareMenu.tsx 100.00% <100.00%> (ø)
src/stores/ActiveWidgetStore.ts 27.50% <0.00%> (-4.76%) ⬇️
src/utils/Reply.ts 44.44% <0.00%> (-2.86%) ⬇️
src/settings/handlers/RoomDeviceSettingsHandler.ts 66.66% <0.00%> (-2.78%) ⬇️
src/components/views/elements/AppTile.tsx 49.42% <0.00%> (-2.11%) ⬇️
src/utils/WidgetUtils.ts 14.76% <0.00%> (-1.60%) ⬇️
src/components/views/elements/PersistentApp.tsx 7.14% <0.00%> (-0.55%) ⬇️
src/stores/WidgetStore.ts 17.24% <0.00%> (-0.41%) ⬇️
src/stores/widgets/StopGapWidget.ts 15.90% <0.00%> (-0.28%) ⬇️
src/components/views/voip/PipView.tsx 0.95% <0.00%> (-0.03%) ⬇️
... and 11 more

Copy link
Contributor

@kerryarchibald kerryarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise looks good

@andybalaam andybalaam enabled auto-merge (squash) March 15, 2022 14:49
@andybalaam andybalaam merged commit e1fdff4 into develop Mar 15, 2022
@andybalaam andybalaam deleted the psf-771-button-for-live-location-share branch March 15, 2022 15:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants