Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Wrapping component to show/hide UI based on UIFeature setting #7585

Merged
merged 5 commits into from
Jan 25, 2022

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Jan 20, 2022

Signed-off-by: Kerry Archibald kerrya@element.io


This change is marked as an internal change (Task), so will not be included in the changelog.

Preview: https://61eea5e64232c0b591455aca--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

Signed-off-by: Kerry Archibald <kerrya@element.io>
@kerryarchibald kerryarchibald added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jan 20, 2022
@kerryarchibald kerryarchibald requested a review from a team as a code owner January 20, 2022 10:47
@kerryarchibald kerryarchibald enabled auto-merge (squash) January 20, 2022 10:47
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally seems fine - just a few relatively minor points

src/settings/helpers/FeatureSettingWrapper.tsx Outdated Show resolved Hide resolved
src/settings/helpers/FeatureSettingWrapper.tsx Outdated Show resolved Hide resolved
src/settings/helpers/FeatureSettingWrapper.tsx Outdated Show resolved Hide resolved
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
@kerryarchibald kerryarchibald merged commit b481fc0 into develop Jan 25, 2022
@kerryarchibald kerryarchibald deleted the pse-271/ui-feature-wrapper-el branch January 25, 2022 09:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants