This repository was archived by the owner on Sep 11, 2024. It is now read-only.
unit test Notifications.tsx #7468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kerry Archibald <kerrya@element.io>
kerryarchibald
added
the
T-Task
Signed-off-by: Kerry Archibald <kerrya@element.io>
t3chguy
approved these changes
Jan 6, 2022
Member
t3chguy
left a comment
t3chguy
left a comment
There was a problem hiding this comment.
Not a huge fan of the super long line constants in the text fixture, those are not super maintainable for when push rules change over time in the spec or we add more tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kerry Archibald kerrya@element.io
I'll make changes to
Notificationsin upcoming work to improve screen reader experience. Test it first.This change is marked as an internal change (Task), so will not be included in the changelog.
Preview: https://61d5c639ea9ab06a03431b1e--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.