Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix possible infinite loop on widget start #7071

Merged
merged 2 commits into from
Nov 4, 2021
Merged

Fix possible infinite loop on widget start #7071

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd92d53
fix 15494 infinit loop on widget start error
toger5 Nov 2, 2021
a94f610
change message to error from log
toger5 Nov 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/components/views/elements/AppTile.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ export default class AppTile extends React.Component<IProps, IState> {
this.sgWidget.on("ready", this.onWidgetReady);
this.startWidget();
} catch (e) {
logger.log("Failed to construct widget", e);
logger.error("Failed to construct widget", e);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it fine to than also change this to an error?

this.sgWidget = null;
}
}
Expand All @@ -241,7 +241,13 @@ export default class AppTile extends React.Component<IProps, IState> {
private iframeRefChange = (ref: HTMLIFrameElement): void => {
this.iframe = ref;
if (ref) {
if (this.sgWidget) this.sgWidget.start(ref);
try {
if (this.sgWidget) {
this.sgWidget.start(ref);
}
} catch (e) {
logger.error("Failed to start widget", e);
}
} else {
this.resetWidget(this.props);
}
Expand Down