This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Remove custom LoggedInView::shouldComponentUpdate logic #6046
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request reduces the work that needs to be done on every sync by approximately half. It scraps the second part of the call stack
LoggedInView::shouldComponentUpdate, would ALWAYS returntrue. And you can find the following code on theonSynccallbackThe comment regarding why
shouldComponentUpdatewas written this way is also now irrelevant as whenever a logout occurs an action is dispatched and theLoggedInViewis unmounted