Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

@germain-gg
Copy link
Contributor

This pull request reduces the work that needs to be done on every sync by approximately half. It scraps the second part of the call stack

Screen Shot 2021-05-17 at 14 34 21

LoggedInView::shouldComponentUpdate, would ALWAYS return true. And you can find the following code on the onSync callback

this.setState({
    syncErrorData: null,
});

The comment regarding why shouldComponentUpdate was written this way is also now irrelevant as whenever a logout occurs an action is dispatched and the LoggedInView is unmounted

@germain-gg germain-gg requested a review from a team May 17, 2021 13:52
@germain-gg germain-gg merged commit f67ba57 into develop May 17, 2021
@germain-gg germain-gg deleted the gsouquet/sync-perf branch May 17, 2021 14:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants