Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

@t3chguy
Copy link
Member

@t3chguy t3chguy commented May 11, 2021

@t3chguy t3chguy requested review from a team and niquewoodhouse and removed request for a team and niquewoodhouse May 11, 2021 16:03
@niquewoodhouse
Copy link
Contributor

@nadonomy I just want to justify my overkill with the feedback button in these designs!

  • Same component keeps it simple to edit/remove/maintain
  • Being overly loud with it for the first release will hopefully lead to more early feedback > hopefully improve early versions
  • Can be removed/amended later when we have more of a handle on feedback
  • Being overly loud with it will give non-technical users more of a chance to feedback, where they currently have none.

I had a bunch of other suggestions but they're not feasible in time for the next RC/need more time.

@t3chguy t3chguy requested review from a team and niquewoodhouse May 11, 2021 16:29
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me code wise, thanks! 😄

@nadonomy
Copy link
Contributor

@nadonomy I just want to justify my overkill with the feedback button in these designs!

@niquewoodhouse consider the overkill justified! I think the consistency of execution makes it really easy to develop blindness to them if you want to. Plus, we can always remove them in future if they turn out to be too much. Thanks for actioning quickly!

@t3chguy t3chguy merged commit ea9be0d into develop May 11, 2021
@t3chguy t3chguy deleted the t3chguy/fix/17238 branch May 12, 2021 08:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add feedback capture modal for Spaces

5 participants