Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

@aaronraimist
Copy link
Contributor

No description provided.

Signed-off-by: Aaron Raimist <aaron@raim.ist>
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looks good - thanks for taking care of this!

"Share decryption keys for room history when inviting users": "Při pozvání uživatelů sdílet dešifrovací klíče pro historii místnosti",
"Manage & explore rooms": "Spravovat a prozkoumat místnosti",
"Message search initilisation failed": "Inicializace vyhledávání zpráv se nezdařila",
"Message search initialisation failed": "Inicializace vyhledávání zpráv se nezdařila",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing strings in the translations ends up causing conflicts with weblate - we only commit the output of yarn i18n and leave the rest to weblate to handle

Copy link
Contributor Author

@aaronraimist aaronraimist Apr 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but doesn't that end up meaning the translators have to retranslate it? Or is weblate smart enough to figure out the source string changed but only a little bit so it's probably the same word?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they'd have to re-translate it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, Weblate is annoying enough to manage that we tend to avoid conflicts at all costs. Yes, it means translations are lost and need to be re-done.

Copy link
Contributor Author

@aaronraimist aaronraimist May 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright I will manually put the old translations into Weblate then once this gets merged

This reverts commit 284b9e4.

Signed-off-by: Aaron Raimist <aaron@raim.ist>
@aaronraimist aaronraimist requested a review from turt2live May 11, 2021 18:43
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@turt2live turt2live merged commit e38d27f into matrix-org:develop May 14, 2021
@aaronraimist aaronraimist deleted the initialisation branch May 14, 2021 02:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants