This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Fix password change popup message #5791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Needs DCO sign-off as per https://github.com/matrix-org/matrix-js-sdk/blob/develop/CONTRIBUTING.rst#sign-off |
Fixed bad error message when providing bad old password during password change. Signed-off-by: Marek Matys <themarcq@gmail.com>
jryans
changed the title
turt2live
suggested changes
Mar 26, 2021
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
The code looks to do something, but we need a bit of information in the PR description for what the broken behaviour is, what the new behaviour looks like, and what sorts of errors we expect to surface now.
If you have an issue link, that would be great to add as well.
Contributor
Author
Added explanations in the description |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bad error message when providing bad old password during password change.
Broken behaviour:
When providing an incorrect old password in password change form in user settings, element gets a response from synapse with error message inside "message" field. It expects it in "error" field so the popup message shows "HTTP status 401"
Expected behaviour after change:
The popup says whatever comes from synapse. "Wrong password" in this example.
This looks like element-hq/element-web#4365 but this PR doesn't address showing the same popup twice as described in the issue. It was not observed on most current synapse-element combo.