This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Support replying with a message command #5686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Townsend <robin@robin.town>
robintown
force-pushed
the
reply-commands
branch
from
ad55f67 to
5636204
Compare
Member
Author
|
Can someone please retrigger the build? It should succeed now that matrix-org/matrix-js-sdk#1618 is merged. |
turt2live
approved these changes
Mar 24, 2021
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
Thanks for taking a look at this! Apologies for the massive delay on receiving review - it looks like it got a bit lost in the queue (oops).
Unfortunately I'm going to lag it by another day or so as we have a release candidate being cut and prior experience with this area of code tends to result in a bit of unforeseen problems. To help give it the maximum amount of testing, I'd like to merge it immediately after that RC is cut. Sorry for the added delay, but we're almost there!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the reply parts of element-hq/element-web#11170 and element-hq/element-web#12081. This depends on matrix-org/matrix-js-sdk#1618.