This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Lock widget room ID when added #5607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the widget room ID available to widget URL templates so that it's locked to the room the widget was added in. Fixes element-hq/element-web#16337
jryans
force-pushed
the
jryans/tally-ho
branch
from
4abe043 to
e462987
Compare
turt2live
approved these changes
Feb 2, 2021
Collaborator
Author
|
Types are expected to fail for the moment, we'll need to rev |
This was referenced Feb 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the widget room ID available to widget URL templates so that it's
locked to the room the widget was added in.
Fixes element-hq/element-web#16337
Depends on matrix-org/matrix-widget-api#30