This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Label unlabeled avatar button in event panel #5585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for working on this. Please update the PR or each commit with your sign off as described in CONTRIBUTING.rst. It also looks like you'll need to regenerate strings by running |
Contributor
jryans
changed the title
Contributor
Author
|
Sorry, will get to it this week.
|
ndarilek
force-pushed
the
label-base-avatar
branch
from
9775001 to
2782f5d
Compare
Contributor
Author
|
Should be fixed now, please let me know if everything is good. |
Signed-off-by: Nolan Darilek <nolan@thewordnerd.info>
ndarilek
force-pushed
the
label-base-avatar
branch
from
2782f5d to
e5d5e1c
Compare
jryans
approved these changes
Mar 30, 2021
Collaborator
jryans
left a comment
jryans
left a comment
There was a problem hiding this comment.
Thanks, looks like this is ready to go! 😄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now, this button is unlabeled, and I'm not quite sure what it does. It appears to bring up the actions toolbar for a message, but not always. In any case, I labeled it "Avatar" so it at least has some context. Then, if someone says to click on the message avatar to view the available actions, screen reader users know what they're doing.