This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Improve SSO auth flow #5578
Merged
Improve SSO auth flow #5578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use replaceState instead of a redirect to strip the loginToken Put user into the same post-auth flows of E2ESetup Skip UIA prompt in this post-auth flow, happy path is a server grace period
For better brand adherance. Also removes old support for https IdP icons.
Fixes Fallback UIA postmessage interface Auto-closes SSO UIA tab when the user has completed the flow within it Error for when auth stage is restarted because it failed
t3chguy
force-pushed
the
t3chguy/sso_fixes
branch
from
f7973fd to
1761a4e
Compare
jryans
approved these changes
Jan 28, 2021
Collaborator
jryans
left a comment
jryans
left a comment
There was a problem hiding this comment.
Thanks, looks like a great improvement! 😄
| @@ -0,0 +1,3 @@ | |||
| <svg width="25" height="24" viewBox="0 0 25 24" fill="none" xmlns="http://www.w3.org/2000/svg"> | |||
Collaborator
There was a problem hiding this comment.
(Off-topic) I'm not really sure why we have an element-icons directory at all... But anyway, it's been around for a while.
Member
Author
There was a problem hiding this comment.
I think it was for when the rebrand replaced a bunch but not all of the icons
Co-authored-by: J. Ryan Stinnett <jryans@gmail.com>
t3chguy
added
the
X-Release-Blocker
jryans
approved these changes
Jan 29, 2021
Collaborator
jryans
left a comment
jryans
left a comment
There was a problem hiding this comment.
Feel free to merge if ready!
| border-color: #3c5a99; | ||
| color: #ffffff; | ||
| } | ||
| .mx_SSOButton.mx_SSOButton_brand_google { |
Collaborator
There was a problem hiding this comment.
Hmm, no colours needed for Google now?
Member
Author
There was a problem hiding this comment.
Indeed, the branding guidelines show it as a colourful logo on a white button. The old figma for it was white logo on red button but thats Google+
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires element-hq/element-web#16292
Fixes element-hq/element-web#16219
Reviewing commit-by-commit is recommended.