Add VoIP user mapper #5560
Add VoIP user mapper #5560
Conversation
The accompanying element-web PR with the config documentation should explain what this is & why. Internally, this breaks the assumption that call.roomId is the room that the call appears in for the user. call.roomId may now be a 'virtual' room while the react SDK actually displays it in a different room. React SDK always stores the calls under the user-facing rooms, and provides a function to get the user-facing room for a given call.
jryans
left a comment
jryans
left a comment
There was a problem hiding this comment.
Overall looks good, just curious about the configuration.
src/settings/Settings.ts
Outdated
| default: null, | ||
| }, | ||
| "voip_mxid_translate_pattern": { | ||
| supportedLevels: LEVELS_UI_FEATURE, // not a UI feature, but same level (config only, maybe .well-known in future) |
There was a problem hiding this comment.
Hmm, reusing it for a non-UI feature seems a bit strange to me... Is there a reason you want it to participate in the settings system? For config-only things, we've typically just read it out of the config directly with SdkConfig.get().thing. Your docs PR also suggests its not part of "settings", but just floating in the config sea.
There was a problem hiding this comment.
oh, good point - I did originally have it as a setting but then realised exactly what you've pointed out, and failed to remove the settings entry - good spot.
|
Also hope this is the intended way to use the VisibilityProvider |
Seems reasonable enough to me at least... 😄 |
The accompanying element-web PR with the config documentation should
explain what this is & why. Internally, this breaks the assumption
that call.roomId is the room that the call appears in for the user.
call.roomId may now be a 'virtual' room while the react SDK actually
displays it in a different room. React SDK always stores the calls
under the user-facing rooms, and provides a function to get the
user-facing room for a given call.