This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Wire up MSC2931 widget navigation #5527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Tests are expected to fail due to lack of branch matching with the widget-api. |
jryans
suggested changes
Jan 11, 2021
Collaborator
jryans
left a comment
jryans
left a comment
There was a problem hiding this comment.
Seems good overall, just a question on the wording.
turt2live
added a commit
to element-hq/element-web
that referenced
this pull request
Jan 17, 2021
Consistency with matrix-org/matrix-react-sdk#5527
jryans
approved these changes
Jan 18, 2021
Collaborator
jryans
left a comment
jryans
left a comment
There was a problem hiding this comment.
Looks good, thanks for working on it! 😄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#16006
Requires matrix-org/matrix-widget-api#27
Demo of it working (requested capability, navigating to a room then a permalink):
2020-12-29.12-28-42.mp4