Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

event-index: Pass the user/device id pair when initializing the event index. - #5312

Merged
poljar merged 2 commits into
developfrom
poljar/seshat-keytar
Oct 14, 2020
Merged

event-index: Pass the user/device id pair when initializing the event index.#5312
poljar merged 2 commits into
developfrom
poljar/seshat-keytar

Conversation

@poljar

@poljar poljar commented Oct 13, 2020

Copy link
Copy Markdown
Contributor

This extends the base event index manager to pass the user id and device id when initializing the event index, this is needed so we store the passphrase under a per user/device specific key.

This is a breaking change.

The element web part is found at element-hq/element-web#15455.
The element desktop part is found at element-hq/element-desktop#147.

Comment thread src/indexing/BaseEventIndexManager.ts Outdated
Comment thread src/indexing/EventIndexPeg.js Outdated
Comment thread src/indexing/EventIndexPeg.js Outdated
Comment thread src/indexing/EventIndexPeg.js Outdated
@poljar

poljar commented Oct 13, 2020

Copy link
Copy Markdown
Contributor Author

@stoically will this mess up radicale-native?

@stoically

stoically commented Oct 13, 2020

Copy link
Copy Markdown
Contributor

Seems non-breaking since the seshat API didn't change and the RN javascript part will just ignore the additional arguments (for now) - thanks for the heads-up! @poljar

@poljar
poljar merged commit f3958e4 into develop Oct 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants