Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

[Release] Show verification status in the room summary card - #5196

Merged
turt2live merged 3 commits into
release-v3.4.0from
travis/e2e-iconography
Sep 11, 2020
Merged

[Release] Show verification status in the room summary card#5196
turt2live merged 3 commits into
release-v3.4.0from
travis/e2e-iconography

Conversation

@turt2live

Copy link
Copy Markdown
Member

#5195 to release - see #5195 for details.

@turt2live turt2live added the X-Release-Blocker This affects the current release cycle and must be solved for a release to happen label Sep 10, 2020
@turt2live
turt2live force-pushed the travis/e2e-iconography branch from 9239e0f to 14f6d9e Compare September 10, 2020 19:53
@turt2live
turt2live requested a review from a team September 10, 2020 19:57
@turt2live

Copy link
Copy Markdown
Member Author

I don't know what the build system is smoking - the E2EStatus is definitely exported.

@turt2live

Copy link
Copy Markdown
Member Author

.. or not. The enum doesn't exist on the release branch.

Comment thread src/components/views/right_panel/RoomSummaryCard.tsx Outdated
Comment thread src/components/views/right_panel/RoomSummaryCard.tsx Outdated
@turt2live
turt2live requested a review from jryans September 11, 2020 15:06

const isRoomEncrypted = useIsEncrypted(cli, room);
const roomContext = useContext(RoomContext);
const e2eStatus = roomContext['e2eStatus'];

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const e2eStatus = roomContext['e2eStatus'];
const e2eStatus = roomContext.e2eStatus;

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have types for this, so it will fail the linter.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(for context, because RoomContext has been TSified on develop but not in the RC)

};

const isRoomEncrypted = useIsEncrypted(cli, room);
const roomContext = useContext(RoomContext);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I am missing how the E2E status gets into this context, but presumably you have tested it...

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested it. No idea how it works, and no idea how the code I copy/pasted works.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I am missing how the E2E status gets into this context, but presumably you have tested it...

The context contains the full RoomView state (IState)
See RoomView doing <RoomContext.Provider value={this.state}>

@turt2live
turt2live merged commit fe0eea8 into release-v3.4.0 Sep 11, 2020
@turt2live
turt2live deleted the travis/e2e-iconography branch September 11, 2020 16:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

X-Release-Blocker This affects the current release cycle and must be solved for a release to happen

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants