This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Communities v2 prototype: DM copy updates - #5153
Merged
Merged
Conversation
turt2live
changed the title
turt2live
marked this pull request as ready for review
August 28, 2020 19:23
jryans
approved these changes
Sep 2, 2020
|
|
||
| if (kind === 'suggestions' && TagOrderStore.getSelectedPrototypeTag()) { | ||
| const summary = GroupStore.getSummary(TagOrderStore.getSelectedPrototypeTag()); | ||
| const communityName = summary?.profile?.name || TagOrderStore.getSelectedPrototypeTag(); |
Collaborator
There was a problem hiding this comment.
Ah cool, didn't realise we can use this ?. syntax now, yay! 😍
Member
Author
There was a problem hiding this comment.
tbh I completely forgot about it up until writing this 😀
It showed up as supported when we started supporting typescript
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prototype behaviour: